Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/facebook/react.git. Pull mirroring updated .
  1. Mar 27, 2025
    • Mofei Zhang's avatar
      [compiler][be] Test runner (snap) now uses tsup bundled plugin · 591de871
      Mofei Zhang authored
      Currently, `babel-plugin-react-compiler` is bundled with (almost) all external dependencies. This is because babel traversal and ast logic is not forward-compatible. Since `babel-plugin-react-compiler` needs to be compatible with babel pipelines across a wide semvar range, we (1) set this package's babel dependency to an early version and (2) inline babel libraries into our bundle.
      
      A few other packages in `react/compiler` depend on the compiler. This PR moves `snap`, our test fixture compiler and evaluator, to use the bundled version of `babel-plugin-react-compiler`. This decouples the babel version used by `snap` with the version used by `babel-plugin-react-compiler`, which means that `snap` now can test features from newer babel versions (see https://github.com/facebook/react/pull/32742).
      591de871
    • lauren's avatar
      [ci] Skip yarn install on cache hit (#32757) · 5f232d72
      lauren authored
      We currently already do this in runtime_build_and_test, we can reuse the
      same technique in other workflows to speed them up.
      5f232d72
    • lauren's avatar
      [crud] Revert CRUD overload (#32741) · 313332d1
      lauren authored
      Cleans up this experiment. After some internal experimentation we are
      deprioritizing this project for now and may revisit it at a later point.
      313332d1
    • Rick Hanlon's avatar
      Fix ownerStackLimit feature gating for tests (#32726) · f99c9fea
      Rick Hanlon authored
      https://github.com/facebook/react/pull/32529 added a dynamic flag for
      this, but that breaks tests since the flags are not defined everywhere.
      
      However, this is a static value and the flag is only for supporting
      existing tests. So we can override it in the test config, and make it
      static at built time instead.
      f99c9fea
  2. Mar 26, 2025
    • Sebastian Markbåge's avatar
      Warn for duplicate ViewTransition names (#32752) · 8ac25e52
      Sebastian Markbåge authored
      This adds early logging when two ViewTransitions with the same name are
      mounted at the same time. Whether they're part of a View Transition or
      not.
      
      This lets us include the owner stack of each one. I do two logs so that
      you can get the stack trace of each one of the duplicates.
      
      It currently only logs once for each name which also avoids the scenario
      when you have many hits for the same name in one commit. However, we
      could also possibly log a stack for each of them but seems noisy.
      
      Currently we don't log if a SwipeTransition is the first time the pair
      gets mounted which could lead to a View Transition error before we've
      warned. That could be a separate improvement.
      8ac25e52
    • Sebastian Markbåge's avatar
      Avoid double logging component render time (#32749) · f9e1b160
      Sebastian Markbåge authored
      This got moved into the functional component and class component case
      statements here:
      https://github.com/facebook/react/commit/0de1233fd180969f7ffdfc98151922f2466ceb1f.
      So that we could separate the error case for class components.
      
      However, due to a faulty rebase this got restored at the top as well.
      Leading to double component renders being logged.
      
      In the other offscreen reconnect passes we don't do this in each case
      statement but still once at the top. The reason this doesn't matter is
      because use the PerformedWork flag and that is only set for function and
      class components. Although maybe it should be set for expensive DOM
      components too and then we have to remember this.
      f9e1b160
    • lauren's avatar
      [ci] Fix param casing (#32748) · 4845e16c
      lauren authored
      Casing was incorrect.
      
      Tested by running locally with a PAT.
      
      ```
      $ scripts/release/download-experimental-build.js --commit=2d40460c
      Command failed: gh attestation verify artifacts_combined.zip --repo=facebook/react
      
      Error: failed to fetch attestations from facebook/react: HTTP 404: Not Found (https://api.github.com/repos/facebook/react/attestations/sha256:23d05644f9e49e02cbb441e3932cc4366b261826e58ce222ea249a6b786f0b5f?per_page=30)
      `gh attestation verify artifacts_combined.zip --repo=facebook/react` (exited with error code 1)
      
      $ scripts/release/download-experimental-build.js --commit=2d40460c --noVerify
      ⠼ Downloading artifacts from GitHub for commit 2d40460c)  5%                  0.1m, estimated 1.6m
      ✓ Downloading artifacts from GitHub for commit 2d40460c) 9.5 secs
      An experimental build has been downloaded!
      
      You can download this build again by running:
        scripts/download-experimental-build.js --commit=2d40460c
      ```
      4845e16c
    • lauren's avatar
      [ci] Fix incorrect condition (#32746) · 553a175c
      lauren authored
      Oops, missed this when I switched it from checking if its a fork to
      checking if its from this repo.
      553a175c
  3. Mar 25, 2025
  4. Mar 24, 2025
  5. Mar 22, 2025
  6. Mar 21, 2025