This project is mirrored from https://github.com/angular/angular.git.
Pull mirroring updated .
- May 14, 2020
-
-
Misko Hevery authored
-
Misko Hevery authored
-
- May 13, 2020
-
-
cexbrayat authored
The `FormStyle` enum offers two options, and the explanation of the difference between the two can be found on the CLDR official website. Sadly, the link changed and the one currently referenced is a dead-end. This commit fixes the link. PR Close #37069
-
Kara Erickson authored
The deprecation notice for platform-webworker APIs is too prescriptive and notes that we will remove the package in version 10. Since we are not planning to do this for version 10, this commit updates the notice to read "a future version of Angular". PR Close #37052
-
Sonu Kapoor authored
This commit fixes the routing variable in the `ngOnit` life-cyle event from `activatedRoute` to `route`. Closes #36885 PR Close #36905
-
Judy Bogart authored
add new feature recommendation to existing content include references from aot-compiler.md and template-typecheck.md PR Close #34549
-
Misko Hevery authored
This reverts commit 078b0be4. The original commit was a work around for a bug in CLI. That bug was fixed in the CLI, as a result this change is no longer needed and is being reverted. PR Close #37074
-
Sonu Kapoor authored
This commit fixes a minor typo issue within the bazel documentation and removes unnecessary spacing. PR Close #37043
-
Paul Gschwendtner authored
As per our discussion in the dev-infra sync meeting, we don't want to have all dependencies show up as peer dependencies. Instead, we only want to have larger dependencies such as `typescript` or buildifier as peer dependencies. Tslib is also included for the sake of it being generally a peer dependency of all Angular framework packages. The rationale is that Yarn is smart enough to collapse packages if all satisfy a given range. This means that we don't necessarily need to have all dependencies as peer dependencies. The initial idea was to keep all dependencies as peer dependencies so that we have control over duplication of packages as downloading multiple packages w/ different versions impacts local dev, CI and caches. At the same time though, we don't want to bother with setting up peer dependencies all the time. Not every consumer of the shared dev-infra package would like to manually specify `yaml` or `multimatch` etc. in the project `package.json`. Hence we decided to go with a hybrid approach where only more impactful dependencies are peer dependencies, and other smaller ones can be standard depdencies that are usually collapsed by Yarn anyway. Also this commit removes tslib from build targets that don't rely on it. PR Close #36980
-
Jan-Niklas W authored
In the code example of the AsyncValidator example there was an aliased import for the rxjs operator `of`. To align with the RxJS docs it should just use a plain import of `of` PR Close #36856
-
Michiel Kikkert authored
The message can be improved by removing the unneeded ‘the’ (x2). Before: Angular is running in the development mode. Call enableProdMode() to enable the production mode. After: Angular is running in development mode. Call enableProdMode() to enable production mode. Closes #36570 PR Close #36571
-
Judy Bogart authored
rework content to meet current documentation standards and conventions, structure as tutorial document PR Close #36465
-
- May 12, 2020
-
-
David Shevitz 🔵 authored
It makes sense that the lead technical writer should be allowed to approve changes to DOCS: Marketing. The inspriration for this change came to the current lead technical writer in a vision, or perhaps it was a fugue state caused by too little caffeine. No one knows. It's still a good idea though. PR Close #37014
-
Keen Yee Liau authored
This commit refactors TS-only utility functions to a separate file so that they could be shared with Ivy language service. A separate ts_library rule is created so that there is no dependency on `compiler` and `compiler-cli` to make the compilation fast and light-weight. The method `getPropertyAssignmentFromValue` is modified slightly to improve the ergonomics of the function. PR Close #36984
-
Judy Bogart authored
rework content to meet current documentation standards and conventions, structure as task-oriented document PR Close #36374
-
Andrew Kushnir authored
Prior to this change, the `template` instruction logic was located in the `instructions/container.ts` file alongside embedded view instructions. Since unused embedded view instructions are removed in a previous commit, this commit renames `container.ts` -> `template.ts`, since only template-related instructions were retained. PR Close #34715
-
Andrew Kushnir authored
This commit performs a cleanup and removes unused embedded view instructions and corresponding tests. PR Close #34715
-
- May 09, 2020
-
-
Ajit Singh authored
All migration guides did not have a direct link to access them so added them to the side nav in the section updating to version 9 for direct access, it also helps to add right side nav to these migration guides Fixes #33582 PR Close #34979
-
ajitsinghkaler authored
Clicking on a link may take us to an extenal source, which may lead to user leaving angular.io unintentionally. Added visual cues on external links so that user knows which links are external and which are intenal to angular.io. Fixes #17620 PR Close #36601
-
Ayaz Hafiz authored
ASTs for property read and method calls contain information about the entire span of the expression, including its receiver. Use cases like a language service and compile error messages may be more interested in the span of the direct identifier for which the expression is constructed (i.e. an accessed property). To support this, this commit adds a `nameSpan` property on - `PropertyRead`s - `SafePropertyRead`s - `PropertyWrite`s - `MethodCall`s - `SafeMethodCall`s The `nameSpan` property already existed for `BindingPipe`s. This commit also updates usages of these expressions' `sourceSpan`s in Ngtsc and the langauge service to use `nameSpan`s where appropriate. PR Close #36826
-
Keen Yee Liau authored
This commit adds a Compiler interface that wraps the actual ngtsc compiler. The language-service specific compiler manages multiple typecheck files using the Project interface, creating and adding ScriptInfos as necessary. This commit also adds `overrideInlineTemplate()` method to the mock service so that we could test the Compiler diagnostics feature. PR Close #36930
-
Alan Agius authored
With this change we disable SauceLabs tests on Safari and iOS as they are current broken. Issue to investigate further: #36975 PR Close #36973
-
Alan Agius authored
With a previous change we add FireFox Extended Support Release (ESR) to the list of supported browsers. With this change we now add this above mentioned browser to list of tested browsers and also update several other browsers. Removed browsers because they are no longer supported: - iOS 10 and 11 - Safari 10 and 11 Added - Firefox 68 (Current ESR version) - Safari 12 and 13 - iOS Safari 12 and 13 Updated - Update Chrome to 81 - Updated Firefox to 76 PR Close #36973
-
Alan Agius authored
With this change we add FireFox Extended Support Release (ESR) to the list of supported browsers. The ESR latest version is used mainly in corporate environments (intranet applications, etc.) due to its support and stability guarantees. PR Close #36973
-
George Kalpakas authored
Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/b7d7ee9bd...15edb0231): **Modified** - help/generate.json - help/new.json **Removed** - help/get.json - help/set.json ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/440275c34...15edb0231) since PR #36981: **Removed** - help/get.json - help/set.json ## Closes #36950 Closes #36981 PR Close #37005
-
Joey Perrott authored
Migrate to use a typescript file rather than a javascript file for defining the ng-dev config file. This will allow long term for the config to rely on the types while writing the config, avoiding errors. PR Close #37017
-
Joey Perrott authored
Previously ng-dev loaded the config through a javascript file, this change allows for the loaded file to be either javascript or typescript. This enables configurations to be written with type safety. PR Close #37017
-
Alex Rickabaugh authored
-
Ajit Singh authored
In resource.model.ts the interfaces of the resources were defined as classes, these do not use any class properties and are only used for type checking. So, changed them from class to interface. PR Close #36958
-
David Shevitz 🔵 authored
While creating the new tutorial section, I hit o instead of i when typing the word 'tooltip.' This is understandable, as they are right next to each other on the keyboard. I might move to the Dvorak keyboard layout to avoid such errors in the future. PR Close #36955
-
Lars Gyrup Brink Nielsen authored
web worker platform. Minor grammar/stylistic changes. Inline documentation for the PlatformLocation service instead mentions @angular/platform-server. Typos corrected, minor grammar and stylistic changes. PR Close #36953
-
Sonu Kapoor authored
Closes #36775 PR Close #36778
-
Santosh Yadav authored
change to aot docs to include changes after angular 9 aot is true for new applications created, also it will be updated to aot true once app is updated using ng update PR Close #35487
-
Joey Perrott authored
Migrate to the new .ng-dev-config.js file for providing a configuration to ng-dev. This is being done as a result of the previous commit which updated the ng-dev command to expect this new file. PR Close #36918
-
Joey Perrott authored
Migrating to a js file for providing a configuration allows for more extensive configuration at run time. This allows for configs to include logic and move beyond static values found in JSON files. PR Close #36918
-
- May 08, 2020
-
-
Alex Rickabaugh authored
-
Alex Rickabaugh authored
-
Alex Rickabaugh authored
Some projects include .js source files (via the TypeScript allowJs option). Previously, the compiler would attempt to tag these files for shims, which caused errors as the regex used to create shim filenames assumes a .ts file. This commit fixes the bug by filtering out non-ts files during tagging. PR Close #36987
-
Paul Gschwendtner authored
In past versions of the View Engine compiler, we added a warning that is printed whenever the compiler comes across an Angular declaration with a constructor that does not match suitable DI tokens. The warning mentioned that in `v6.x` it will turn into an actual error. This actually happened as expected for most cases. e.g. the constructor of `@NgModule`, `@Component`'s, `@Pipe`'s etc will be checked and an error will be reported if constructor is not DI compatible. The warning has never been removed though as it was still relevant for unprovided injectables, or injectables serialized into summaries of the Angular compiler. As of version 10, classes that use Angular features need an Angular decorator. This includes base classes of services that use the lifecycles Angular feature. Due to this being a common pattern now, we can remove the warning in View Engine. The warning is not correct, and also quite confusing as it mentions the planned removal in `v6.x`. Resolves FW-2147. PR Close #36985
-
Tidi authored
Prior to this commit, number input fields would to fire valueChanges twice: once for `input` events when typing and second for the `change` event when the field lost focus (both events happen at once when using the increment and decrement buttons on the number field). Fixes #12540 BREAKING CHANGE: Number inputs no longer listen to the `change` event. * Tests which trigger `change` events need to be updated to trigger `input` events instead. * The `change` event was in place to support IE9, as we found that `input` events were not fired with backspace or cut actions. If you need to maintain IE9 support, you will need to add a change event listener to number inputs and call the `onChange` method of `NumberValueAccessor` manually. * Lastly, old versions of WebDriver would synthetically trigger the `change` event on `WebElement.clear` and `WebElement.sendKeys`. If you are using an old version of WebDriver, you may need to update tests to ensure `input` events are triggered. For example, you could use `element.sendKeys(Keys.chord(Keys.CONTROL, "a"), Keys.BACK_SPACE);` in place of `element.clear()`. PR Close #12540 PR Close #36087
-