Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/angular/angular.git. Pull mirroring updated .
  1. May 14, 2020
  2. May 13, 2020
    • cexbrayat's avatar
      docs(common): fix CLDR website link in FormStyle doc (#37069) · 4f3ac1d9
      cexbrayat authored
      The `FormStyle` enum offers two options, and the explanation of the difference between the two can be found on the CLDR official website. Sadly, the link changed and the one currently referenced is a dead-end. This commit fixes the link.
      
      PR Close #37069
      4f3ac1d9
    • Kara Erickson's avatar
      docs(platform-webworker): remove mention of version 10 (#37052) · d7c70caa
      Kara Erickson authored
      The deprecation notice for platform-webworker
      APIs is too prescriptive and notes that we will
      remove the package in version 10. Since we are
      not planning to do this for version 10, this
      commit updates the notice to read "a future
      version of Angular".
      
      PR Close #37052
      d7c70caa
    • Sonu Kapoor's avatar
      docs: fixes `ngOnit` routing variable (#36905) · 2cddeabc
      Sonu Kapoor authored
      This commit fixes the routing variable in the `ngOnit` life-cyle event from
      `activatedRoute` to `route`.
      
      Closes #36885
      
      PR Close #36905
      2cddeabc
    • Judy Bogart's avatar
      docs: add doc for template type guards to stuctural-directives.md (#34549) · 7addc9f1
      Judy Bogart authored
      add new feature recommendation to existing content
      include references from aot-compiler.md and template-typecheck.md
      
      PR Close #34549
      7addc9f1
    • Misko Hevery's avatar
      Revert "fix(common): `locales/global/*.js` are not ES5 compliant (#36342)" (#37074) · cb6ddfc2
      Misko Hevery authored
      This reverts commit 078b0be4.
      
      The original commit was a work around for a bug in CLI. That bug was fixed in the CLI, as a result this change is no longer needed and is being reverted.
      
      PR Close #37074
      cb6ddfc2
    • Sonu Kapoor's avatar
      docs: minor typo fix in the bazel documentation (#37043) · 681741cd
      Sonu Kapoor authored
      This commit fixes a minor typo issue within the bazel documentation and
      removes unnecessary spacing.
      
      PR Close #37043
      681741cd
    • Paul Gschwendtner's avatar
      build(dev-infra): cleanup package dependencies for shared package (#36980) · 8fe532e5
      Paul Gschwendtner authored
      As per our discussion in the dev-infra sync meeting, we don't want
      to have all dependencies show up as peer dependencies. Instead, we
      only want to have larger dependencies such as `typescript` or buildifier
      as peer dependencies. Tslib is also included for the sake of it being
      generally a peer dependency of all Angular framework packages.
      
      The rationale is that Yarn is smart enough to collapse packages
      if all satisfy a given range. This means that we don't necessarily
      need to have all dependencies as peer dependencies. The initial
      idea was to keep all dependencies as peer dependencies so that
      we have control over duplication of packages as downloading multiple
      packages w/ different versions impacts local dev, CI and caches.
      
      At the same time though, we don't want to bother with setting
      up peer dependencies all the time. Not every consumer of the
      shared dev-infra package would like to manually specify `yaml`
      or `multimatch` etc. in the project `package.json`. Hence we
      decided to go with a hybrid approach where only more impactful
      dependencies are peer dependencies, and other smaller ones can
      be standard depdencies that are usually collapsed by Yarn anyway.
      
      Also this commit removes tslib from build targets that don't
      rely on it.
      
      PR Close #36980
      8fe532e5
    • Jan-Niklas W's avatar
      docs(forms): remove rxjs of alias import in form async validator example (#36856) · 198fc6f1
      Jan-Niklas W authored
      In the code example of the AsyncValidator example there was an aliased
      import for the rxjs operator `of`. To align with the RxJS docs it should
      just use a plain import of `of`
      
      PR Close #36856
      198fc6f1
    • Michiel Kikkert's avatar
      fix(core): correct "development mode" console message (#36571) · 8d8e4196
      Michiel Kikkert authored
      The message can be improved by removing the unneeded ‘the’ (x2).
      
      Before:
      Angular is running in the development mode. Call enableProdMode() to enable the production mode.
      
      After:
      Angular is running in development mode. Call enableProdMode() to enable production mode.
      
      Closes #36570
      
      PR Close #36571
      8d8e4196
    • Judy Bogart's avatar
      docs: refactor dynamic forms topic as tutorial (#36465) · 1e208e8c
      Judy Bogart authored
      rework content to meet current documentation standards and conventions, structure as tutorial document
      
      PR Close #36465
      1e208e8c
  3. May 12, 2020
  4. May 09, 2020
  5. May 08, 2020
    • Alex Rickabaugh's avatar
    • Alex Rickabaugh's avatar
      77d8afb7
    • Alex Rickabaugh's avatar
      fix(compiler-cli): don't try to tag non-ts files as shims (#36987) · 42d1091d
      Alex Rickabaugh authored
      Some projects include .js source files (via the TypeScript allowJs option).
      Previously, the compiler would attempt to tag these files for shims, which
      caused errors as the regex used to create shim filenames assumes a .ts file.
      This commit fixes the bug by filtering out non-ts files during tagging.
      
      PR Close #36987
      42d1091d
    • Paul Gschwendtner's avatar
      fix(compiler): remove outdated and invalid warning for unresolved DI parameters (#36985) · d0280a03
      Paul Gschwendtner authored
      In past versions of the View Engine compiler, we added a warning that is
      printed whenever the compiler comes across an Angular declaration with a
      constructor that does not match suitable DI tokens. The warning mentioned
      that in `v6.x` it will turn into an actual error.
      
      This actually happened as expected for most cases. e.g. the constructor
      of `@NgModule`, `@Component`'s, `@Pipe`'s etc will be checked and an error
      will be reported if constructor is not DI compatible.
      
      The warning has never been removed though as it was still relevant for
      unprovided injectables, or injectables serialized into summaries of the
      Angular compiler.
      
      As of version 10, classes that use Angular features need an Angular decorator.
      This includes base classes of services that use the lifecycles Angular feature.
      Due to this being a common pattern now, we can remove the warning in
      View Engine. The warning is not correct, and also quite confusing as it
      mentions the planned removal in `v6.x`.
      
      Resolves FW-2147.
      
      PR Close #36985
      d0280a03
    • Tidi's avatar
      fix(forms): number input fires valueChanges twice. (#36087) · 97d6d909
      Tidi authored
      Prior to this commit, number input fields would to fire valueChanges twice: once for `input` events when typing and second for the `change` event when the field lost focus (both events happen at once when using the increment and decrement buttons on the number field).
      
      Fixes #12540
      
      BREAKING CHANGE: Number inputs no longer listen to the `change` event.
      * Tests which trigger `change` events need to be updated to trigger `input` events instead.
      * The `change` event was in place to support IE9, as we found that `input` events were not fired with backspace or cut actions. If you need to maintain IE9 support, you will need to add a change event listener to number inputs and call the `onChange` method of `NumberValueAccessor` manually.
      * Lastly, old versions of WebDriver would synthetically trigger the `change` event on `WebElement.clear` and `WebElement.sendKeys`. If you are using an old version of WebDriver, you may need to update tests to ensure `input` events are triggered. For example, you could use `element.sendKeys(Keys.chord(Keys.CONTROL, "a"), Keys.BACK_SPACE);` in place of `element.clear()`.
      
      PR Close #12540
      
      PR Close #36087
      97d6d909