This project is mirrored from https://github.com/angular/angular.git.
Pull mirroring updated .
- Dec 10, 2020
-
-
Joey Perrott authored
-
Pete Bacon Darwin authored
These tests started failing because they had type-check errors in their templates, and a recent commit turned on full template type-checking by default.\ This commit fixes those templates and updates the expected files as necessary. PR Close #40040
-
Julien authored
easier to read PR Close #40036
-
George Kalpakas authored
Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/099ce69de...416dff296): **Modified** - help/add.json - help/build.json - help/config.json - help/doc.json - help/e2e.json - help/extract-i18n.json - help/generate.json - help/new.json - help/serve.json - help/test.json - help/update.json PR Close #40034
-
Jessica Janiuk authored
This adds comp labels to each group defined in the yml file. PR Close #39962
-
Alexey Elin authored
PR Close #39918
-
Aristeidis Bampakos authored
PR Close #39560
-
Christoph Guttandin authored
PR Close #39387
-
nseabourn authored
PR Close #36927
-
- Dec 09, 2020
-
-
Andrew Scott authored
These tests do not pass the typecheck phase of the compiler and fail. The option to disable typechecking was removed recently so these tests need to be fixed to be valid applications. PR Close #40033
-
Benjamin Kindle authored
Forward `getPosition` to `animation_group_player`. PR Close #39983
-
Andrew Scott authored
A couple reasons to justify removing the flag: * It adds code to the compiler that is only meant to support test cases and not any production. We should avoid code in that's only meant to support tests. * The flag enables writing tests that do not mimic real-world behavior because they allow invalid applications PR Close #40013
-
Andrew Scott authored
Rather than returning `null`, we can provide some useful information to the Language Service by returning a symbol for the `addEventListener` function call when the consumer of a binding as an element. PR Close #39312
-
Joey Perrott authored
With the migration to husky@5, the environment variable used to skip husky changed from `HUSKY_SKIP_HOOKS` to `HUSKY`. To continue skipping husky during the merge process as expected, the environment variable used is updated. PR Close #40025
-
devpato authored
PR Close #40029
-
Andrew Scott authored
Add myself (atscott) to the list of approvers for language-service PRs. PR Close #40027
-
Joey Perrott authored
Exclude the generated build-worker.js file from formatting as it is generated and not subject to formatting restrictions. PR Close #40012
-
Joey Perrott authored
Generates a local copy of the build-worker file to allow it to be loaded at runtime in a forked process. PR Close #40012
-
Christoph Guttandin authored
Errors thrown by calling serviceWorker.register() are now passed to the global ErrorHandler. Fixes #39913 PR Close #39990
-
George Kalpakas authored
Previously, due to the way the AngularJS and Angular clean-up processes interfere with each other when removing an AngularJS element that contains a downgraded Angular component, the data associated with the host element of the downgraded component was not removed. This data was kept in an internal AngularJS cache, which prevented the element and component instance from being garbage-collected, leading to memory leaks. This commit fixes this by ensuring the element data is explicitly removed when cleaning up a downgraded component. NOTE: This is essentially the equivalent of #26209 but for downgraded (instead of upgraded) components. Fixes #39911 Closes #39921 PR Close #39965
-
George Kalpakas authored
This commit removes some unused parameters, properties and variables in various `@angular/upgrade` functions. PR Close #39965
-
JoostK authored
The prior usage of a ternary expression caused the code to be formatted in a weird way, so this commit replaces the ternary with an `if` statement. PR Close #39961
-
JoostK authored
Prior to this change the interpolation config value was cast to `[string, string]` without checking whether there really were two string values available. This commit extracts the logic of parsing the interpolation config into a separate function and adds a check that the array contains exactly two strings. PR Close #39961
-
JoostK authored
This change allows the `AstObject` and `AstValue` types to provide their represented type as a generic type argument, which is helpful for documentation and discoverability purposes. PR Close #39961
-
JoostK authored
This allows the code generation to correspond with a type, which is helpful for documentation and discoverability purposes. This does not offer any type-safety with respect to the actually generated code. PR Close #39961
-
Daniel Eisterhold authored
PR Close #36102
-
Misko Hevery authored
This reverts commit eee878c0.
-
Misko Hevery authored
This reverts commit fbfc7dff.
-
Kalle Järvenpää authored
Removed two extra closing parentheses in docs. PR Close #37164
-
JiaLiPassion authored
Remove the work around solution for the `npm pack`, we can now use `npm_package.pack` rule of bazel, since the windows os issue has been fixed here https://github.com/bazelbuild/rules_nodejs/commit/bc36519 PR Close #39636
-
JiaLiPassion authored
Update the version `rules_nodejs` to 2.3.1, so the `npm_package.pack` rule can now work on windows os. PR Close #39636
-
Andrew Scott authored
refactor(compiler-cli): TemplateTypeChecker with checkTypeOfAttributes=false should still work (#39537) When the compiler option `checkTypeOfAttributes` is `false`, we should still be able to produce type information from the `TemplateTypeChecker`. The current behavior ignores all attributes that map to directive inputs. This commit includes those attribute bindings in the TCB but adds the "ignore for diagnostics" marker so they do not produce errors. This way, consumers of the TTC (the Language Service) can still get valid information about these attributes even when the user has configured the compiler to not produce diagnostics/errors for them. PR Close #39537
-
Pete Bacon Darwin authored
The previous image referred to "Mr IQ". The example application (and the content of the referring guide) actually uses "Dr IQ". Closes #34823 PR Close #40022
-
m-ahmadi authored
This commit rephrases a confusing sentence, and also adds more info to another sentence to be more understandable. PR Close #37230
-
Pete Bacon Darwin authored
The previous tutorial content referred to a `Routes` member of `AppRoutingModule`, which is not correct. Instead there is a `routes` variable that is passed to the `forRoot()` method when configuring the `AppRoutingModule`. Replaces #36583 PR Close #40023
-
George Kalpakas authored
Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/2eb97bf5b...099ce69de): **Modified** - help/build.json - help/generate.json - help/serve.json PR Close #40020
-
Joey Perrott authored
Separate retrieving targeted branches from printing the branches to allow for other tools to better integrate with the results. PR Close #39897
-
Panagiotis Kyriazopoulos authored
1. In line 25 changed the word "components" to "component's". 2. In line 66 changed the phrase "you never refer to them" to "you should never refer to them". 3. Appended the paragraph containing the above phrase in a `div` with the class `alert is-helpful`. PR Close #39246
-
ankitkaushik24 authored
Remove the statements where mentions the component in the `entryComponents` array inside `NgModule` metadata. This is not required since Angular version 9. PR Close #39242
-
profanis authored
docs: how to create a custom Attribute decorator in a child component and use it from a parent component (#38721) Aside from using the @input() decorator, we can use the @Attrbitute decorator too. Of course, those two are different and support different causes. I expected to see a working example on the Attribute Bindings section, but I didn't find one. This PR depicts the usage of the Attribute decorator between two components PR Close #38721
-