Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/angular/angular.git. Pull mirroring updated .
  1. Mar 01, 2018
  2. Feb 28, 2018
  3. Feb 27, 2018
  4. Feb 26, 2018
    • George Kalpakas's avatar
      fix(upgrade): fix empty transclusion content with AngularJS@>=1.5.8 (#22167) · a9a0e27e
      George Kalpakas authored
      The function provided by `ngUpgrade` as `parentBoundTranscludeFn` when
      upgrading a component with transclusion, will break in AngularJS v1.5.8+
      if no transclusion content is provided. The reason is that AngularJS
      will try to destroy the transclusion scope (which would not be needed
      any more). But since the transcluded content comes from Angular, not
      AngularJS, there is no transclusion scope to destroy.
      This commit fixes it by providing a dummy scope object with a no-op
      `$destroy()` method.
      
      Fixes #22175
      
      PR Close #22167
      a9a0e27e
    • George Kalpakas's avatar
      fix(upgrade): correctly handle `=` bindings in `@angular/upgrade` (#22167) · 66383901
      George Kalpakas authored
      Previously, having a `=` binding on an upgraded components would result
      in setting the corresponding property to an EventEmitter function. This
      should only happen for `&` bindings.
      This commit rstrores the correct behavior.
      
      Note:
      The issue was only present in the dynamic version of `ngUpgrade`. The
      static version worked as expected.
      The error did not show up in tests, because in AngularJS v1.5.x a
      function would be serialized to an empty string in interpolations, thus
      making them indistinguishable from uninitialized properties (in the
      view). The serialization behavior changed in AngularJS v1.6.x, making
      the errors visible.
      
      PR Close #22167
      66383901
    • George Kalpakas's avatar
      test(upgrade): run tests against multiple AngularJS versions (#22167) · 1eb54132
      George Kalpakas authored
      Fixes #19332
      
      PR Close #22167
      1eb54132
    • George Kalpakas's avatar
      refactor(upgrade): use correct paths for imports (#22167) · 6c9c173e
      George Kalpakas authored
      `packages/upgrade/static/src` is anymlink to `packages/upgrade/src`.
      Still, using the correct paths (e.g. using
      `@angular/upgrade/static/src/...` for `@angula/upgrade/static` specs
      ensures that the module loader (e.g. SystemJS) can map the imports to
      the same instances.
      
      PR Close #22167
      6c9c173e
    • George Kalpakas's avatar
      1e08a945
  5. Feb 24, 2018
  6. Feb 23, 2018
  7. Feb 22, 2018
  8. Feb 21, 2018