This project is mirrored from https://github.com/flutter/flutter.git.
Pull mirroring updated .
- Nov 07, 2024
-
-
Ben Konyi authored
The test was immediately checking the contents of stdout after the daemon indicated that the hot reload had completed. This could cause a race since the reloaded code may not have had time to execute. Fixes https://github.com/flutter/flutter/issues/158245
-
- Nov 06, 2024
-
-
Valentin Vignal authored
Contributes to https://github.com/flutter/flutter/issues/130459 It adds a test for - `examples/api/lib/widgets/image/image.loading_builder.0.dart`
-
Martin Kustermann authored
Make flutter_tools use newest package:{native_assets_builder,native_assets_cli,native_toolchain_c} (#158214) Almost all of the code is just adopting to changes to the APIs of `package:native_assets_builder`, `package:native_assets_cli` and `package:native_toolchain_c` There's only two semantic changes * Removes a test that checks for a verification error if a build hook produces a static library if the preferred linking mode is dynamic: => The test is written in a very hacky way. By monkey patching the build config.json that flutter build actually made. This monkey patching relies on package:cli_config which is now no longer used. => The actual code that checks for this mismatch lives in dart-lang/native repository and is tested there. So there's really no need to duplicate that. * The `package:native_assets_builder` no longer knows about code assets. This is something a user of that package (e.g. flutter tools) adds. Now the dry-run functionality will invoke build hooks who produce code assets without an architecture. => The `package:native_assets_builder` used to expand such a code asset to N different code assets (one for each supported architecture) => This logic was now moved to flutter tools. => In the near future we're going to this dry-run complexity, which will then also get rid of this uglyness (of expanding to all archs of an OS).
-
Bruno Leroux authored
## Description Fix the formatting of some `RawScrollbar` examples. Fix and rename one test file (name without `_test` suffix).
-
Bruno Leroux authored
## Description This PR fixes some typos on `MenuAnchor` and improve the readability of a `DropdownMenu` test utility function. @justinmc I'm still considering creating a test utils file for DropdownMenu but there are few utilities and I'm worried that helper functions in utils file will cripple completion results (not a big deal because it is just for people working on the framework) but I think this should be used carefully. For instance the function `getButtonMaterial` would have to be renamed to something less generic if exposed more broadly (`getMenuItemButtonMaterial` for instance).
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/a3741d6248b7...f03f11300a9d 2024-11-05 robert.ancell@canonical.com Document fields in FlEngine (flutter/engine#56266) 2024-11-05 matanlurey@users.noreply.github.com Add missing TOC. (flutter/engine#56389) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
LouiseHsu authored
Update to https://github.com/flutter/flutter/issues/156733
-
Matan Lurey authored
Closes https://github.com/flutter/flutter/issues/60675. From what I can tell `FakeAsync` wasn't necessary to making this be testable (or at least it isn't anymore?)
-
Aparin Kirill authored
This PR fixes the `shouldCloseOnMinExtent` flag in `draggable_scrollable_sheet.dart`. *The `shouldCloseOnMinExtent` flag was not functioning correctly in the `DraggableScrollableSheet` widget. This PR ensures that the flag is properly handled, preventing the sheet from closing when it reaches the minimum extent if the flag is set to false. Before/after screenshots are not applicable for this change.* In the code sample below, before my fix, the sheet would close when scrolled down. After my fix, it behaves as expected by respecting the `shouldCloseOnMinExtent` parameter. ### Code Sample ```dart import 'package:flutter/material.dart'; Future<void> main() async { runApp(const MaterialApp( home: Home(), )); } class Home extends StatelessWidget { const Home({ super.key, }); @override Widget build(BuildContext context) => Scaffold( body: Center( child: FilledButton( onPressed: () async => showModalBottomSheet( context: context, isScrollControlled: true, isDismissible: false, builder: (context) => DraggableScrollableSheet( expand: false, maxChildSize: 0.9, minChildSize: 0.25, initialChildSize: 0.5, shouldCloseOnMinExtent: false, builder: (context, scrollController) => Navigator( onGenerateRoute: (settings) => MaterialPageRoute( settings: settings, builder: (context) => ListView.builder( controller: scrollController, itemExtent: 100, itemCount: 100, itemBuilder: (context, index) => Center( child: Text('$index'), ), ), ), ), ), ), child: const Text('Open sheet'), ), ), ); } ```
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/e5e06c97c33c...a3741d6248b7 2024-11-05 jason-simmons@users.noreply.github.com Increase timeouts for Linux Fuchsia and Linux Web Framework Tests builders (flutter/engine#56387) 2024-11-05 chris@bracken.jp iOS: Use standard Obj-C cflags for ios_test_flutter (flutter/engine#56384) 2024-11-05 robert.ancell@canonical.com Remove unnecessary method for getting engine switches (command line). (flutter/engine#56265) 2024-11-05 robert.ancell@canonical.com Remove FlScrollingViewDelegate (flutter/engine#56270) 2024-11-05 chris@bracken.jp fml: delete scoped_nsobject.h,mm (flutter/engine#56382) 2024-11-05 skia-flutter-autoroll@skia.org Roll Skia from b3be9cb59fe8 to 82175b411c80 (2 revisions) (flutter/engine#56383) 2024-11-05 jason-simmons@users.noreply.github.com [Impeller] Delete any remaining GL objects during destruction of the ReactorGLES (flutter/engine#56361) 2024-11-05 mdebbar@google.com [web] Switch all fonts to WOFF2 (non-split) (flutter/engine#56035) 2024-11-05 jonahwilliams@google.com [Impeller] exploit content context options' perfect hash function. (flutter/engine#56360) 2024-11-05 skia-flutter-autoroll@skia.org Roll Skia from 7989f782dbf4 to b3be9cb59fe8 (6 revisions) (flutter/engine#56380) 2024-11-05 skia-flutter-autoroll@skia.org Roll Dart SDK from b39c729740eb to 3e840340c412 (1 revision) (flutter/engine#56377) 2024-11-05 jonahwilliams@google.com [Impeller] match Skia's old VMA default block size. (flutter/engine#56368) 2024-11-05 chris@bracken.jp iOS: Refactor ShellTestPlatformViewMetal (flutter/engine#56370) 2024-11-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from amgHXcqtplha8LuI_... to z1otZzn3yKuGnu1st... (flutter/engine#56374) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from amgHXcqtplha to z1otZzn3yKuG If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Matan Lurey authored
Unblocks landing https://github.com/flutter/engine/pull/56329. @jtmcdole monorepo can't come soon enough...
-
Matan Lurey authored
I checked google3 as well and couldn't find any reference.
-
Matan Lurey authored
Description intentionally left blank :)
-
Nate Wilson authored
I saw that there was a private `_Shaker` class in input_decorator.dart that does the exact same thing as the [MatrixTransition](https://main-api.flutter.dev/flutter/widgets/MatrixTransition-class.html) API. ("hide whitespace" for tiny diffs!)
-
Flutter GitHub Bot authored
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Mac_benchmark animated_complex_opacity_perf_macos__e2e_summary" } --> Issue link: https://github.com/flutter/flutter/issues/157423
-
Andrew Kolos authored
I've noticed Linux tool_integration_tests 5_5 has come very close to timing out. See https://github.com/flutter/flutter/issues/155317 for more context, I am not 100% confident that increasing the subsharding here will help given that we just very recently increased subsharding from 4 to 5, but the results could be interesting regardless. <details> <summary> Pre-launch checklist </summary> </details>
-
Valentin Vignal authored
Contributes to https://github.com/flutter/flutter/issues/130459 It adds a test for - `examples/api/lib/widgets/scrollbar/raw_scrollbar.2.dart`
-
Andrew Kolos authored
While doing some hacking on `Cache` in https://github.com/flutter/flutter/pull/158081, I noticed that [`Cache.test`](https://github.com/flutter/flutter/blob/de9318275391a6d2f10ae33c576f4113b25fd156/packages/flutter_tools/lib/src/cache.dart#L139) allows the caller to tell Cache to use some given directory as the flutter root (instead of depending on the static global [`Cache.flutterRoot`](https://github.com/flutter/flutter/blob/4f3976a4f2b722d26c3353158dcd26590859dde0/packages/flutter_tools/lib/src/cache.dart#L206)). This has a default value, `/cache`. However, `/cache` is an unintuitive name for the root directory of a Flutter installation. This led to confusion when updating some tests. I wanted to create `/bin/cache/engine-dart-sdk.stamp` for tests, but in reality I needed to create `/cache/bin/cache/engine-dart-sdk.stamp`. This PR changes this default to the current directory of the file system (which I'm guessing is `/` for all intents and purposes). <details> <summary> Pre-launch checklist </summary> </details>
-
Jenn Magder authored
To convince `xcdevice observe` to redirect to stdout it's being launched in an interactive shell `/usr/bin/script -t 0 /dev/null /usr/bin/arch -arm64e xcrun xcdevice observe --usb` https://github.com/flutter/flutter/blob/1cc8a07ace699de12fcd31ac9e8fcfa14f1017e2/packages/flutter_tools/lib/src/macos/xcdevice.dart#L261-L263 When the `flutter` command exits, the interactive script process is terminated, but not its jobs `xcdevice observe --usb`. Instead of `-9` sigterm killing the interactive script, send it a [`SIGHUP`](https://linux.die.net/Bash-Beginners-Guide/sect_12_01.html#sect_12_01_01_02) (signal hangup) during `XCDevice.dispose()`, which will exit its processes. Add a shutdown hook to ensure `dispose` is run when the process exits. Fixes https://github.com/flutter/flutter/issues/73859
-
Kishan Rathore authored
Adjust the gap between TextField prefix/suffix and its content. Results in a small visual change for TextFields that use prefix and/or suffix.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/f56401062e42...e5e06c97c33c 2024-11-05 skia-flutter-autoroll@skia.org Roll Skia from b2bb3af36da3 to 7989f782dbf4 (1 revision) (flutter/engine#56358) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Andrew Kolos authored
Helps with https://github.com/flutter/flutter/issues/157845. See that thread for more info. <details> <summary> Pre-launch checklist </summary> </details>
-
Polina Cherkasova authored
Reland2: Revert "Revert "Add a warning/additional handlers for parsing`synthetic-package`."" (#158184) Reverts flutter/flutter#158078
-
Polina Cherkasova authored
Reverts flutter/flutter#158076
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/796afa35071d...721943194945 2024-11-05 jonahwilliams@google.com [vector_graphics*] Relax dependency constraints of vector_graphics, vector_graphics_codec, vector_graphics_compiler, flutter_svg (flutter/packages#8018) 2024-11-04 kallentu@google.com [various] Add `missing_code_block_language_in_doc_comment` lint to flutter/packages. (flutter/packages#6473) 2024-11-04 stuartmorgan@google.com [various] Update example apps to Kotlin 1.9.0 (flutter/packages#7998) 2024-11-04 cedvandenbosch@gmail.com [go_router] add current state getter (flutter/packages#7651) 2024-11-04 jessiewong401@gmail.com Applied Gradle Plugins Declaratively for Multiple Plugin Example Apps (flutter/packages#7968) 2024-11-04 engine-flutter-autoroll@skia.org Roll Flutter from f86b7772 to 8591d0c1 (16 revisions) (flutter/packages#8015) 2024-11-04 stuartmorgan@google.com [camera_windows] Revert: Support image streams on Windows platform (flutter/packages#7951) 2024-11-02 stuartmorgan@google.com [camera] Use Pigeon for Windows C++->Dart (flutter/packages#8001) 2024-11-02 kevmoo@users.noreply.github.com [script/tool] update dependencies (flutter/packages#7992) 2024-11-01 engine-flutter-autoroll@skia.org Roll Flutter from 0fe61534 to f86b7772 (16 revisions) (flutter/packages#8000) 2024-11-01 kevmoo@users.noreply.github.com [path_parsing] deprecate utility functions that should be private (flutter/packages#7993) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- Nov 05, 2024
-
-
Martin Kustermann authored
Make native asset integration test more robust, thereby allowing smooth auto-update of packages via `flutter update-packages` (#158170) Currently the bot that runs `flutter update-packages` makes PRs that fail due to native asset integration tests failing. The root cause is due to incompatible versions on `package:logging`. The bot tries to upgrade `package:logging` from `1.2.0` to `1.3.0`. Here's what seems to happen: * `flutter update-packages` will update `dev/integration_tests/link_hook/pubspec.yaml` with `package:logging` to `1.3.0` (as it does with all other `pubspec.yaml` files in the flutter repository) * `flutter create --template=package_ffi` will generate a template with `package:logging` `^1.2.0` * The test in question * creates ffi template (which will use `^1.2.0`) * make it depend on `dev/integration_tests/link_hook` (which uses `=1.3.0`) * changes logging dependency from the template from `^1.2.0` to `=1.2.0` IMHO * `flutter update-packages` is doing what it's supposed to * `flutter create --template=package_ffi` can generate templates with versions it determines (maybe there are use cases where we want to generate templates with older versions) * The problematic part is the test: * it makes the generated template depend on `link_hook` and * changes template generated pubspec to use pinned dependencies This PR makes the test package (created via template) use the pinned package versions from `dev/integration_tests/link_hook` (for dependencies that are common among the two). All other dependencies that the template has on top of `dev/integration_tests/link_hook` it can pin as it does currently. This will give us deterministic CI behavior (as we use flutter pined packages and remaining deps being pinned via template) It avoids changing the `flutter update-packages` and `flutter create --template=package_ffi` (as their behavior seems reasonable) Should fix https://github.com/flutter/flutter/issues/158135
-
Mohellebi abdessalem authored
Readability change to `flutter.groovy`, align on null assignment, reduce unused scope for some methods, apply static where possible (#157471) removed public modifier from this methods :`getVersionCode` , `getVersionName`. add static to :`pluginSupportsAndroidPlatform` ,`buildGradleFile`,`settingsGradleFile` `getCompileSdkFromProject` ,`getAssembleTask` refactor `==null` usage to `:?` to unify the usage see https://github.com/flutter/flutter/issues/147122 for context
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/7207a8fbec93...f56401062e42 2024-11-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 695831e9a70b to b39c729740eb (1 revision) (flutter/engine#56372) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Valentin Vignal authored
Contributes to https://github.com/flutter/flutter/issues/130459 It adds a test for - `examples/api/lib/widgets/scrollbar/raw_scrollbar.shape.0.dart`
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/418609dd5b58...7207a8fbec93 2024-11-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 0addd35215d0 to 695831e9a70b (3 revisions) (flutter/engine#56371) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Bruno Leroux authored
## Description This PR introduces some utility functions to simplify some DropdownMenu tests. The main purpose is to centralize and document how tests should find menu items, because it is tricky as there are two occurrences of each widgets and using '.last' is mandatory: ```dart Finder findMenuItemButton(String label) { // For each menu items there are two MenuItemButton widgets. // The last one is the real button item in the menu. // The first one is not visible, it is part of _DropdownMenuBody // which is used to compute the dropdown width. return find.widgetWithText(MenuItemButton, label).last; } ``` ## Related Issue This is extracted from https://github.com/flutter/flutter/pull/157496. ## Tests Refactors many existing tests.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/6271a92a376f...418609dd5b58 2024-11-05 jonahwilliams@google.com remove mock vulkan memory test. (flutter/engine#56367) 2024-11-05 ditman@gmail.com [web] injectPlatformView into correct flutterView (flutter/engine#56334) 2024-11-05 devoncarew@google.com [deps] removed unused deps (dart-lang browser_launcher, clock, bazel_worker, cli_util, csslib, html, json_rpc_2 (flutter/engine#56359) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Flutter GitHub Bot authored
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Linux_pixel_7pro flavors_test" } --> Issue link: https://github.com/flutter/flutter/issues/156955
-
Matan Lurey authored
... to mention because without HTML they work the same as the native renderer! Yay! Post-submit follow-up cleanups to https://github.com/flutter/flutter/pull/158035#pullrequestreview-2414359559 (https://github.com/flutter/flutter/issues/157547).
-
Polina Cherkasova authored
This is to handle Google testing failures for https://github.com/flutter/flutter/pull/158126. We want to update G3 to provide this parameter before merging the full change. Testing is not needed because the change is no-op.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/75acceedca41...6271a92a376f 2024-11-04 matanlurey@users.noreply.github.com Add and document `et cleanup`. (flutter/engine#56327) 2024-11-04 jonahwilliams@google.com [Impeller] check if memory type is host coherent, avoid flush. (flutter/engine#56350) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Matan Lurey authored
Closes https://github.com/flutter/flutter/issues/158120. This PR restores the skipped test, moving it (and the test utility only used by the test) into a standalone file that can be more easily understood. As part of the change the version of `native_assets_cli` is now derived from the (checked-in) `package_ffi/pubspec.yaml.tmpl`, meaning that it should be hard to get into a bad state again. /cc @christopherfujino (You are welcome to review, but otherwise will defer to Brandon and Victor).
-
Matan Lurey authored
Closes https://github.com/flutter/flutter/issues/157547.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/f880b56b6ede...75acceedca41 2024-11-04 skia-flutter-autoroll@skia.org Roll Dart SDK from f238183cf168 to 0addd35215d0 (1 revision) (flutter/engine#56357) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Nate Wilson authored
Changes: - Remove 2<sup>nd</sup> person language from docs ([relevant style guideline](https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md#use-the-passive-voice-recommend-do-not-require-never-say-things-are-simple)) - Update a bunch of spots to be more explicit about `WidgetStateMouseCursor`. - `WidgetStateFoo` constructors now accurately describe what happens when used incorrectly. - Gave `WidgetStateProperty` a little section about equality checks.
-