This project is mirrored from https://github.com/flutter/flutter.git.
Pull mirroring updated .
- Dec 22, 2024
-
-
Jonah Williams authored
Fixes https://github.com/flutter/flutter/issues/160593 Primitive Restart cannot be used on some (All?) Adreno's because it causes a dramatic performance regression. Opt out and use the GLES strategy. Refactors the batch submit command buffer capability into workarounds_vk
-
Danny Tuppeny authored
There have been some reports of the Flutter daemon not starting up properly (for ex. https://github.com/flutter/flutter/issues/143625), but it turns out that when starting successfully, it just prints "Starting device daemon..." and then nothing more. This is confusing and can lead users to think other issues are because the daemon hasn't started properly. There's not a great hook to print that this "finished" starting up (because it does async polling in the background), so I just updated the message of the text and moved it to after the creation of the daemon. Fixes https://github.com/flutter/flutter/issues/143625 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [N/A] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by:
Andrew Kolos <andrewrkolos@gmail.com>
-
Yegor authored
Fixes https://github.com/flutter/flutter/issues/160405
-
John McDole authored
Fixes the bash integration test missing a file.
-
- Dec 21, 2024
-
-
Michael Goderbauer authored
Only observation: It forces a type on `_` parameters.
-
Michael Goderbauer authored
-
Christopher Fujino authored
This is no longer working after the monorepo merge: https://github.com/flutter/flutter/issues/160670. That issue tracks instead teaching the `Linux ci_yaml flutter roller` to roll both sets of configurations.
-
Bruno Leroux authored
## Description This PR reverts `DropdownMenu` changes from https://github.com/flutter/flutter/pull/155757. Automatically rematching the `initialSelection` breaks some use cases. It is more flexible to let users manipulate the text field content using the TextEditingController. ## Related Issue Fixes [Dropdown Menu Creates Infinite Build Loop](https://github.com/flutter/flutter/issues/160196) Fixes [Can no longer initialize non selectable value in DropdownMenu as of flutter version 3.27.1](https://github.com/flutter/flutter/issues/160555) ## Tests Removes 2 regression tests from https://github.com/flutter/flutter/pull/155757. Keeps 2 tests from the original PR (missing test for the initialSelection behavior). Adds 1 tests to avoid regressing this revert.
-
Jonah Williams authored
Refactoring to make sure that we're always tracking the correct layout state.
-
Alexander Aprelev authored
Changes since last roll: ``` fc5db8ea927 Version 3.7.0-267.0.dev 601e85438f3 [tests] Cascade tests for static member and constructor enum shorthands. 4093bdaf5a8 [vm] Change try-catch IL representation. b3ab7e274c5 Elements. Migrate lib/src/generated/ffi_verifier.dart 6e5fb8baa16 [dart2wasm] Add support for dynamic module options. 7bea7d185d4 [dart2wasm] Add indirection for struct initialization. ```
-
Derek Xu authored
Annotate entrypoints in the "isolate spawner" files generated by `flutter test --experimental-faster-testing` (#160694) This fixes the test timeouts (https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20tool_integration_tests_2_5/1951/overview) introduced by the most recent Dart SDK roll (https://github.com/flutter/flutter/commit/895f0e291af00c3d45df0d931900bbad3061b681).
-
Matan Lurey authored
This was done with `sed` and some manual massaging. Closes https://github.com/flutter/flutter/issues/160703. /cc @aam, after this lands we can resume Dart SDK rolls.
-
Christopher Fujino authored
Work around: https://github.com/flutter/flutter/issues/160689. I locally verified that we have not regressed what this was testing (that just invoking `//flutter/bin/dart` will not build the flutter tool).
-
John McDole authored
`update_dart_sdk.(ps1|sh)` is called too late and needs to be called from `shared.(bat|sh)`. Fixes #160640
-
Jonah Williams authored
Fixes https://github.com/flutter/flutter/issues/160480 Both The Impeller and Skia variant of the OES texture rendering use the same shared code path, so the Impeller code must match the weird 1x1 texture behavior of Skia. In addition, we have to add back the TiledTextureContents support, since we need to render a texture with a transform. I had previously tested this but neglected to force the SurfaceTexture path, so I only tested the ImageReader path which does not use a transform.
-
Chris Bracken authored
This is a temporary directory created by Swift Package Manager and should not be checked in. ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
-
Jonah Williams authored
The TransientsAllocator argument to BlitPass::EncodeCommands is completely unused. Delete it (and add a missing IFDEF around the GLES debug labels.).
-
Martin Kustermann authored
In the future a hook may be invoked multiple times with different `supportedAssetTypes` (soon to be renamed to `buildAssetTypes`). The hook should only emit those asset types that are in `supportedAssetTypes` - anything else is an error. Right now flutter happens to invoke hooks only with `Code` asset types, but more asset types are coming, for which this PR is a preparation for.
-
Reid Baker authored
No issue Related to https://github.com/flutter/packages/pull/7985#issuecomment-2557237025 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
-
Alexander Aprelev authored
Changes since last roll: ``` 85569ab5b39 Version 3.7.0-266.0.dev 8c1fa6d05b8 [tfa,aot,dart2wasm] Allow tree-shaking of extension type members independently of their tear-offs 5078a20a6d5 [cfe] Use OffsetMap for BodyBuilder.finishFields a6b0fced839 [tfa,aot,dart2wasm] Retain libraries which only have extensions and extension types 4bcb4b10443 (tag: 3.7.0-265.0.dev) Version 3.7.0-265.0.dev 982b9fad444 [vm] Turn on entry point checking in JIT mode. 04530d578ff Roll dart_style 3.0.1 into the SDK. c2abea31557 [deps] Roll dart-lang/native 3b056e1d500 [dart2wasm] Fix deferred loading tests on optimized configs. ca668b701c3 (tag: 3.7.0-264.0.dev) Version 3.7.0-264.0.dev 54af9b3a39a (tag: 3.7.0-263.0.dev) Version 3.7.0-263.0.dev 72acd9d0ff3 [dart:svg] Add value->newLength parameter name change to templates 57c4da6911d Make Driver.instrumentationService private and final f934e392f2d analyzer: Remove unnecessary Driver.httpServer c5c3544b71f Fix Fuchsia build error. 2f857baba7e [dart2js] Make an check. b3e7e027380 (tag: 3.7.0-262.0.dev) Version 3.7.0-262.0.dev 08252fc9e91 [dartdev] Use VmInteropHandler for invoking sub commands 96c4e4c81f8 [dart2wasm] Use field type instead of global type for static field type. e3e7ca846a8 [gardening] Fix service/uri_mappings_lookup_test. 580107f8474 Migrate generic_type_alias.test 0a5a8f17af8 [vm] Remove BaseIsolate as it serves no purposes anymore. 9820487a3c4 [analyzer] Support enclosingFragments that are local variables dbf60082974 DAS: Support monospaced text (eg code snippets) in generated doc comments 59499d362a2 [dart2wasm] Add support for declaring functions as module elements. a0e1bce4b27 (tag: 3.7.0-261.0.dev) Version 3.7.0-261.0.dev 96fbc264ca1 [dart2wasm] Add indirection for dispatch table calls. d261ded4c72 Bump tools to febccb92d228e678196aa90c109c708ed7ad6ea8 54d62b478d8 [analysis_server] Move Type Hierarchy off ElementLocation to its own internal uri/name encoding b67f61a66c3 [tests] Additional tests for ?? with enum shorthands. e1be04c4704 Implement element and fragment for generic function types a9c3991a7a6 [analysis_server] Migrate LSP Find References to new element model 11904ed3871 [analyzer] Add LinterContext.currentUnit and use it for content in eol_at_end_of_file 38bce3f507d Elements. Migrate test/generated/simple_resolver_test.dart 34cf29701be Elements. Migrate test/src/dart/analysis/search_test.dart e70a91d8e38 [analyzer/linter] Simplify implementation of rule State ee5c4b00840 Roll BoringSSL from 57f525e425a9 to ee0c13ad1808 (22 revisions) 42f0e9aa15b analyzer: Report bad type arg on implicit call 8cc449ac8c1 [dart2wasm] Add utils for pragma reading and updating. 04d70b9fb40 analyzer: Make ResolutionVisitor._libraryElement final d0f34d918f2 [dynamic_modules] Fix multiple_classes/dynamic_interfaces.yaml for vm. 3fba5fb4633 DAS: Seal TypeDecl for simpler switches 946f3287b46 [dart2wasm] Clean up some dead or unnecessary code. 231b463e8fc Roll Fuchsia SDK from 26.20241210.5.1 to 26.20241211.4.1 4e4fec1830b DAS: Correct some broken comment references 69fef4b123c Elements. Use impl types in a few places to avoid casts. ```
-
Martin Kustermann authored
The integration test framework that waits for transitions and (optionally) takes actions on transitions allows to match patterns. If one uses a RegExp pattern than the framework only checks whether a line contains the given RegExp pattern. If one uses a String pattern it matches it exactly. => We add a `Barrier.contains()` and `Multiple.contains()` that allow matching a line with if it contains the String (just like in RegExp) => This makes tests simpler as they don't have to know about the exact padding of progres bar etc. Those may be irrelevant for the purpose of the integration test and only complicate it.
-
- Dec 20, 2024
-
-
Alex Li authored
Resolves #159961 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
-
Jim Graham authored
DlVertices was already half migrated onto the DL geometry classes, this completes the conversion.
-
Jenn Magder authored
Ignore patch versions for this GitHub dependency (https://github.com/flutter/flutter/pull/159440) from dependabot. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
-
Robert Ancell authored
Test consistency achieved.
-
Jonah Williams authored
These tests are slightly flakey due to the macos cache issue. These aren't actually tests, instead the prepopulate an RBE cache - so the failure shouldn't close the tree, because cold caches isn't a failure state (its just unfortunate).
-
Matan Lurey authored
... which is [now merged into the monorepo](https://github.com/flutter/flutter/tree/master/engine/src). Yay!
-
Jackson Gardner authored
This splits the web engine into a build phase and a test phase. This requires a few changes: * Modify the `generate_builder_json.dart` command to produce two separate json builder files, `linux_web_engine_build.json` and `linux_web_engine_test.json`. The former is left as the existing builder with `release_build: true` (which will run in the merge queue) and the latter is added as a new builder that runs in the second CI phase. * Change the `copy_artifacts_step.dart` to pull built artifacts from the GCS bucket when on LUCI, instead of relying on the CAS bucket. This is necessary to do the tests separately from the build. * Move the `felt test --copy-artifacts` command from the build steps to the test steps, since the test steps themselves need to pull from GCS instead of relying on the artifacts being populated by CAS.
-
Jonah Williams authored
* delete null safety stuff since everything is migrated * Filter out engine subdirectory on listing of framework fies.
-
Michael Goderbauer authored
This auto-formats all *.dart files in the repository outside of the `engine` subdirectory and enforces that these files stay formatted with a presubmit check. **Reviewers:** Please carefully review all the commits except for the one titled "formatted". The "formatted" commit was auto-generated by running `dev/tools/format.sh -a -f`. The other commits were hand-crafted to prepare the repo for the formatting change. I recommend reviewing the commits one-by-one via the "Commits" tab and avoiding Github's "Files changed" tab as it will likely slow down your browser because of the size of this PR. --------- Co-authored-by:
Kate Lovett <katelovett@google.com> Co-authored-by:
LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com>
-
Michael Goderbauer authored
This auto-formats all *.dart files in the `engine` subdirectory and enforces that these files stay formatted with a presubmit check.
-
- Dec 19, 2024
-
-
Matan Lurey authored
Closes https://github.com/flutter/flutter/issues/160529.
-
Yegor authored
It takes 30 minutes while all other bots are done in 10-20 minutes. The old Windows build used to test in IE11 and old Edge. Since we stopped testing on those we switched to Chromium, but that doesn't provide any extra signal in addition to what we get from Linux Chromium already.
-
John McDole authored
Several use cases for `origin` as default: * Some github actions checkout the tree * Some users download from flutter.dev and then use `master` Fixes #160558
-
John McDole authored
- only set it when the environment FLUTTER_REALM is present
-
John McDole authored
Hello, Monorepo Part Deux - after adding commit to datastore.
-
- Dec 18, 2024
-
-
John McDole authored
Hello Monorepo.
-
John McDole authored
Adds files from flutter/flaux which contain modifications for the engine structure. The history for engine/ has been edited. Please see flutter/engine for the original PRs.
-
Yegor authored
This needs to work entirely differently in the monorepo world.
-
skia-flutter-autoroll authored
https://dart.googlesource.com/sdk.git/+log/a74650e32880..37bbc285d8d2 2024-12-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-260.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-