This project is mirrored from https://github.com/angular/angular.git.
Pull mirroring updated .
- Dec 20, 2022
-
-
Paul Gschwendtner authored
After discussion initiated in the framework team (by kkostadinov), the team has decided to not keeping the `components-repo-unit-tests` job. This commit removes it. PR Close #48521
-
- Oct 12, 2022
-
-
Dylan Hunn authored
Previously, `setDisabledState` was never called when attached if the control is enabled. This PR fixes the bug, and creates a configuration option to opt-out of the fix. Fixes #35309. BREAKING CHANGE: setDisabledState will always be called when a `ControlValueAccessor` is attached. You can opt-out with `FormsModule.withConfig` or `ReactiveFormsModule.withConfig`. PR Close #47576
-
- Oct 11, 2022
-
-
Kristiyan Kostadinov authored
Updates the version range in the compiler to require at least TypeScript 4.8. Note that I'm keeping the backwards-compatibility layer for 4.7 around for now until internal projects have been migrated to 4.8. BREAKING CHANGE: TypeScript versions older than 4.8 are no longer supported. PR Close #47690
-
- Jul 09, 2022
-
-
Paul Gschwendtner authored
Remove todo PR Close #46743
-
Paul Gschwendtner authored
For the branch rename migration we temporarily had to work from a forked-off branch. Now that all the migration and cleanup Is complete, we can switch to the actual new main branch. This is the last remaining cleanup in the organization as it seems. PR Close #46743
-
- Jun 30, 2022
-
-
Paul Gschwendtner authored
Re-enables the components-repo-unit-tests job. It has previously been disabled but never got re-enabled. PR Close #46604
-
- May 22, 2022
-
-
Joey Perrott authored
Update the saucelabs key for the newly generated key PR Close #46089
-
Joey Perrott authored
Update the saucelabs key for the newly generated key PR Close #46088
-
- Apr 20, 2022
-
-
Paul Gschwendtner authored
Preparation for the framework repo as outlined our planning document. PR Close #45681
-
- Mar 26, 2022
-
-
Paul Gschwendtner authored
For quite some time now, since we started to use Bazel for integration tests, we relied on some size tracking logic that did not actually fully work under Bazel. It was thought that all the necessary CI push/PR information is available to the Bazel test, but that was not the case. This was now fixed with the recent Rules NodeJS v5 update where I made sure the `env.sh` variables are actually available before we write them to the temporary file for the Bazel-access. This now will unveil an issue because payload size goldens would start being based on their branch name. e.g. the golden key in `13.3.x` should not be `master` but `13.3.x`. This makes more sense than `master` as key, but makes things more cumbersome and ideally we would not store the branch name at all (this is a larger change though -- not worth now since we might refactor this anyway). For now we will update the size tracking logic to always use `master` as golden key (like it worked in the past year(s)) With the environment fix we now (again) start uploading payload size results to Firebase. This did not work by accident either. The uploading logic is reliant on the CircleCI commit range which is not working/reliable in upstream branches. This commit removes this reliance on `COMMIT_RANGE` since it's not strictly necessary and currently breaking renovate PRs. We can re-enable this when we have a solution with CircleCI, or a workaround/resolution logic provided in e.g. `ng-dev ci determine-commit-range`. PR Close #45444
-
Paul Gschwendtner authored
Improves stability of the Windows Bazel CI job by installing Bazelisk globally. Also makes the environment helpers more convenient by evaluating the variable assignments directly, simplifying some Bash logic. PR Close #45431
-
Paul Gschwendtner authored
It is totally fine, and expected to use Git Bash for running Bazel on Windows. In fact this is the most common setup for Bazel on Windows and it's unrealistic to run without it. This allows us to remove the old/legacy Powershell setup from CI which is also quite flaky sometimes and does not reproduce how Bazel is used on windows-users dev machines. PR Close #45431
-
- Mar 25, 2022
-
-
Kristiyan Kostadinov authored
Drops support for TypeScript older than 4.6 and removes some workarounds in the compiler. BREAKING CHANGE: TypeScript versions older than 4.6 are no longer supported. PR Close #45394
-
- Feb 26, 2022
-
-
Paul Gschwendtner authored
Fixes the stamping for snapshot builds and the artifact deployment job. Currently the stamped versions will have the `.with-local-changes` version suffix given that we add a file to the Git repo that is just needed for the CircleCI cache key computation. PR Close #45147
-
- Feb 23, 2022
-
-
Paul Gschwendtner authored
This commit attemps to fix the flakiness that shows up sometimes in the `components-repo-unit-tests` job. See: https://app.circleci.com/pipelines/github/angular/angular/43024/workflows/fa9bc546-179a-4215-a7f1-db123efa0fa4/jobs/1126909 We updated Firefox/Chromium in dev-infra, hoping to fix this non-reproducable flakiness (also checked memory/CPU consumption in the test). So far it looks like the update helped in the COMP repo so we should try it here as well. PR Close #45166
-
- Jan 28, 2022
-
-
Paul Gschwendtner authored
Re-enables the components-repo unit tests job that we previously disabled due to the devmode target change that caused conflicts with `angular/components` patching `ng_module.bzl` of `@angular/bazel`. PR Close #44832
-
- Oct 27, 2021
-
-
Paul Gschwendtner authored
Updates the SHA for the components-repo-unit-tests job. Due to us enabling code splittign in the Angular compiler CLI package, the postinstall patches in Angular Components started failing. The latest commit of Angular Components no longer patches any JS files of the compiler-cli, so updating the job unblocks us from enabling code splitting within ESBuild. PR Close #43932
-
- Oct 13, 2021
-
-
Paul Gschwendtner authored
The APF v13 changes have landed in the `angular/components` repository so that the CI check can be re-enabled. PR Close #43798
-
- Oct 06, 2021
-
-
Kristiyan Kostadinov authored
Bumps the minimum required TypeScript version to 4.4.2 and removes the integration tests for 4.1, 4.2 and 4.3. BREAKING CHANGE: TypeScript versions older than 4.4.2 are no longer supported. PR Close #43642
-
- Jul 20, 2021
-
-
Paul Gschwendtner authored
In the past when we had issues with our RBE instance, we wanted to get CI green as soon as possible, and couldn't wait on the components repo to land their RBE instance fix. We manually fixed the RBE instance name using a CI step using `sed`. This is no longer needed if we update to the most recent state of the components repository. PR Close #42875
-
- Apr 29, 2021
-
-
George Kalpakas authored
Previously, the `components-repo-unit-tests` CI job was temporarily disabled due to a version mismatch between the `rules_nodejs` dependency version on the two repos (angular/angular and angular/components). Now that both repos have been updated to a `rules_nodejs` version >=2.0.0, we can re-enable the job and have `@angular/components` unit tests run on every build. PR Close #41816
-
- Jan 15, 2021
-
-
Alexey Elin authored
PR Close #40434
-
- Aug 07, 2020
-
-
JoostK authored
The changes in angular/components#20136 are required to allow the framework tests to succeed. PR Close #38273
-
- Jun 23, 2020
-
-
Paul Gschwendtner authored
Updates to the latest commit of the `angular/components` repository. We need to do this because we removed the `esm5.bzl` output flavour aspect, but an old version of the components repo relied on this file to exist. This is no longer the case, and we can simply update the version of the components repo we can test against. PR Close #37623
-
- May 19, 2020
-
-
Paul Gschwendtner authored
Updates the commit the `components-repo-unit-tests` job runs against. The goal is that we run against a revision that at least contains: https://github.com/angular/components/pull/19336. The new commit contains fixes for a flaky test in the datepicker that we saw failing in the components-repo-unit-tests job too: https://app.circleci.com/pipelines/github/angular/angular/15359/workflows/27ffae7c-a7b8-46a3-9c9e-6dd22ca4734d/jobs/712643. Additionally, with this commit, the components repo unit tests job will use TypeScript 3.9.2, so we can re-enable the job in another commit. PR Close #37176
-
- May 07, 2020
-
-
Paul Gschwendtner authored
Updates the `components-repo-unit-tests` job to https://github.com/angular/components/commit/d3a9ac67d2ef89ca9570c73af41111c796c135ca. We need to update since we added a new diagnostic in ngtsc, and the given commit in the components repo fixes failures caused by the new diagnostic. Note: This commit currently points to a PR as it's unlikely that this fix lands soon, but we want to move forward. There is no downside to doing that as the PR is based on top of the latest components repo `master`. PR Close #36921
-
- May 06, 2020
-
-
Andrew Scott authored
Remove TypeScript 3.6 and 3.7 support from Angular along with tests that ensure those TS versions work. BREAKING CHANGE: typescript 3.6 and 3.7 are no longer supported, please update to typescript 3.8 PR Close #36329
-
Joey Perrott authored
A caching mechanism was put in place to prevent repeated calls to the Github API. As the CI setup no longer relies on calls to the Github API, this caching is no longer necessary. It was discovered that this caching was causing a contention issue for saucelabs testing as the same tunnel was being reused for multiple jobs simultaneously. With this caching mechanism removed the jobs will once again run via separate tunnels. PR Close #36936
-
- Apr 17, 2020
-
-
Joey Perrott authored
Previously our CI during the setup process has made requests to the Github API to determine the target branch and shas. With this change, this information is now determined via git commands using pipeline parameters from CircleCI. PR Close #36500
-
- Apr 02, 2020
-
-
Joey Perrott authored
Update to clang@1.4.0 to gain support for optional changing and nullish coalescing. Because this would trigger a change on >1800 files in the repository, also changes our format enforcement to only be run against changed files. This will allow us to incramentally roll out the value add of the upgraded clang format. PR Close #36203
-
- Mar 26, 2020
-
-
Joey Perrott authored
This is done by requesting the refs and shas for the PR when the env.sh script is run. Additionally, the env.sh script is now setup to write all of the environment variables created to a cache file and subsequent loads of the environment load the values from there. The get-refs-and-shas-for-target.js script now also first attempts to load the refs and shas from an environment variable before falling back to requesting from github via the API. PR Close #36207
-
- Mar 12, 2020
-
-
Greg Magolan authored
* integration tests target definitions in integration/BUILD.bazel updated to use a single dict * payload tracking for integration tests updated to work under Bazel * legacy integration_test CI job removed * integration/run_tests.sh script no longer used in CI so it has been updated for running integration tests locally in the legacy way PR Close #35985
-
- Mar 11, 2020
-
-
Paul Gschwendtner authored
Updates the commit that the `components-repo-unit-tests` job runs against to the latest available commit at time of writing. The motivation for updating is that a lot of changes have been made, and that a upcoming framework PR that fixes check no changes for OnPush components exposed a test failure in `angular/components`. See: https://github.com/angular/components/commit/eae5cf886d6e93e0d189a7974d2615cc448d54e8 PR Close #35961
-
- Feb 19, 2020
-
-
George Kalpakas authored
Previously, we needed to manually specify a ChromeDriver version to download on CI that would be compatible with the browser version provided by the docker image used to run the tests. This was kept in the `CI_CHROMEDRIVER_VERSION_ARG` environment variable. With recent commits, we use the browser provided by `puppeteer` and can determine the correct ChromeDriver version programmatically. Therefore, we no longer need the `CI_CHROMEDRIVER_VERSION_ARG` environment variable. NOTE: There is still one place (the `bazel-schematics` integration project) where a hard-coded ChromeDriver version is necessary. Since I am not sure what is the best way to refactor the tests to not rely on a hard-coded version, I left it as a TODO for a follow-up PR. PR Close #35381
-
- Feb 13, 2020
-
-
Joey Perrott authored
PR Close #35348
-
- Feb 11, 2020
-
-
Paul Gschwendtner authored
Updates the commit the `components-repo-unit-tests` job runs against. We need at least https://github.com/angular/components/commit/2ec7254f88c4865e0de251f74c27e64c9d00d40a which fixes a Ngcc postinstall patch conflict that required us to temporarily disable the job in #35079. PR Close #35123
-
- Feb 07, 2020
-
-
Paul Gschwendtner authored
In the past we had connecitivity issues on Saucelabs. Browsers on mobile devices were not able to properly resolve the `localhost` hostname through the tunnel. This is because the device resolves `localhost` or `127.0.0.1` to the actual Saucelabs device, while it should resolve to the tunnel host machine (in our case the CircleCI VM). In the past, we simply disabled the failing devices and re-enabled the devices later. At this point, the Saucelabs team claimed that the connecitivy/proxy issues were fixed. Saucelabs seems to have a process for VMs which ensures that requests to `localhost` / `127.0.0.1` are properly resolved through the tunnel. This process is not very reliable and can cause tests to fail. Related issues have been observed/mentioned in the Saucelabs support docs. e.g. https://support.saucelabs.com/hc/en-us/articles/115002212447-Unable-to-Reach-Application-on-localhost-for-Tests-Run-on-Safari-8-and-9-and-Edge https://support.saucelabs.com/hc/en-us/articles/225106887-Safari-and-Internet-Explorer-Won-t-Load-Website-When-Using-Sauce-Connect-on-Localhost In order to ensure that requests are always resolved through the tunnel, we add our own domain alias in the CircleCI's hosts file, and enforce that it is always resolved through the tunnel (using the `--tunnel-domains` SC flag). Saucelabs devices by default will never resolve this domain/hostname to the actual local Saucelabs device. PR Close #35171
-
- Jan 28, 2020
-
-
Joey Perrott authored
PR Close #34955
-
- Jan 24, 2020
-
-
Paul Gschwendtner authored
We rename the `material-unit-tests` job to `components-repo-unit-tests` because the job runs all unit tests found in the Angular Components repository. This includes the Angular CDK, Angular Material and more. Also the repository has been renamed from `angular/material2` to `angular/components` in the past. PR Close #34898
-
- Jan 23, 2020
-
-
Joey Perrott authored
Since we always set up bazel on both our windows and linux CI runs, we should consider this configuration part of the environment setup. PR Close #34834
-