Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/angular/angular.git. Pull mirroring updated .
  1. Dec 20, 2022
  2. Oct 12, 2022
    • Dylan Hunn's avatar
      fix(forms): call `setDisabledState` on `ControlValueAcessor` when control is enabled (#47576) · 96b7fe93
      Dylan Hunn authored
      Previously, `setDisabledState` was never called when attached if the control is enabled. This PR fixes the bug, and creates a configuration option to opt-out of the fix.
      
      Fixes #35309.
      
      BREAKING CHANGE: setDisabledState will always be called when a `ControlValueAccessor` is attached. You can opt-out with `FormsModule.withConfig` or `ReactiveFormsModule.withConfig`.
      
      PR Close #47576
      96b7fe93
  3. Oct 11, 2022
    • Kristiyan Kostadinov's avatar
      feat(core): drop support for TypeScript 4.6 and 4.7 (#47690) · ed11a13c
      Kristiyan Kostadinov authored
      Updates the version range in the compiler to require at least TypeScript 4.8. Note that I'm keeping the backwards-compatibility layer for 4.7 around for now until internal projects have been migrated to 4.8.
      
      BREAKING CHANGE:
      TypeScript versions older than 4.8 are no longer supported.
      
      PR Close #47690
      ed11a13c
  4. Jul 09, 2022
  5. Jun 30, 2022
  6. May 22, 2022
  7. Apr 20, 2022
  8. Mar 26, 2022
    • Paul Gschwendtner's avatar
      ci: make payload size tracking script work with CircleCI and Bazel limitation (#45444) · 1177b4e2
      Paul Gschwendtner authored
      For quite some time now, since we started to use Bazel for integration tests, we
      relied on some size tracking logic that did not actually fully work under Bazel.
      
      It was thought that all the necessary CI push/PR information is available to the
      Bazel test, but that was not the case. This was now fixed with the recent Rules NodeJS
      v5 update where I made sure the `env.sh` variables are actually available before we
      write them to the temporary file for the Bazel-access.
      
      This now will unveil an issue because payload size goldens would start being based
      on their branch name. e.g. the golden key in `13.3.x` should not be `master` but
      `13.3.x`. This makes more sense than `master` as key, but makes things more
      cumbersome and ideally we would not store the branch name at all (this is a larger
      change though -- not worth now since we might refactor this anyway). For now we will
      update the size tracking logic to always use `master` as golden key (like it worked
      in the past year(s))
      
      With the environment fix we now (again) start uploading payload size results to Firebase.
      This did not work by accident either. The uploading logic is reliant on the CircleCI
      commit range which is not working/reliable in upstream branches. This commit
      removes this reliance on `COMMIT_RANGE` since it's not strictly necessary and
      currently breaking renovate PRs. We can re-enable this when we have a solution with
      CircleCI, or a workaround/resolution logic provided in e.g. `ng-dev ci determine-commit-range`.
      
      PR Close #45444
      1177b4e2
    • Paul Gschwendtner's avatar
      ci: improve stability of windows bazel CI job (#45431) · fed76306
      Paul Gschwendtner authored
      Improves stability of the Windows Bazel CI job by
      installing Bazelisk globally.
      
      Also makes the environment helpers more convenient by
      evaluating the variable assignments directly, simplifying
      some Bash logic.
      
      PR Close #45431
      fed76306
    • Paul Gschwendtner's avatar
      ci: make windows circleci job more robust and use git bash (#45431) · a48683be
      Paul Gschwendtner authored
      It is totally fine, and expected to use Git Bash for running Bazel
      on Windows. In fact this is the most common setup for Bazel on Windows
      and it's unrealistic to run without it.
      
      This allows us to remove the old/legacy Powershell setup from CI
      which is also quite flaky sometimes and does not reproduce how
      Bazel is used on windows-users dev machines.
      
      PR Close #45431
      a48683be
  9. Mar 25, 2022
  10. Feb 26, 2022
    • Paul Gschwendtner's avatar
      ci: fix stamping for builds performed in CI (#45147) · e56472d3
      Paul Gschwendtner authored
      Fixes the stamping for snapshot builds and the artifact deployment job.
      Currently the stamped versions will have the `.with-local-changes` version
      suffix given that we add a file to the Git repo that is just
      needed for the CircleCI cache key computation.
      
      PR Close #45147
      e56472d3
  11. Feb 23, 2022
  12. Jan 28, 2022
  13. Oct 27, 2021
    • Paul Gschwendtner's avatar
      ci: update commit for components-repo-unit-tests job (#43932) · e2f9dcff
      Paul Gschwendtner authored
      Updates the SHA for the components-repo-unit-tests job. Due to
      us enabling code splittign in the Angular compiler CLI package,
      the postinstall patches in Angular Components started failing. The
      latest commit of Angular Components no longer patches any JS files of
      the compiler-cli, so updating the job unblocks us from enabling code
      splitting within ESBuild.
      
      PR Close #43932
      e2f9dcff
  14. Oct 13, 2021
  15. Oct 06, 2021
  16. Jul 20, 2021
    • Paul Gschwendtner's avatar
      ci: remove RBE workaround from `components-repo-unit-tests` job (#42875) · 7271ad15
      Paul Gschwendtner authored
      In the past when we had issues with our RBE instance, we wanted
      to get CI green as soon as possible, and couldn't wait on the
      components repo to land their RBE instance fix. We manually
      fixed the RBE instance name using a CI step using `sed`.
      
      This is no longer needed if we update to the most recent
      state of the components repository.
      
      PR Close #42875
      7271ad15
  17. Apr 29, 2021
    • George Kalpakas's avatar
      ci: re-enable the `@angular/components` unit tests (#41816) · 641fa694
      George Kalpakas authored
      Previously, the `components-repo-unit-tests` CI job was temporarily
      disabled due to a version mismatch between the `rules_nodejs`
      dependency version on the two repos (angular/angular and
      angular/components).
      
      Now that both repos have been updated to a `rules_nodejs` version
      >=2.0.0, we can re-enable the job and have `@angular/components` unit
      tests run on every build.
      
      PR Close #41816
      641fa694
  18. Jan 15, 2021
  19. Aug 07, 2020
  20. Jun 23, 2020
    • Paul Gschwendtner's avatar
      ci: update components-repo-unit-tests job commit (#37623) · 12f674f4
      Paul Gschwendtner authored
      Updates to the latest commit of the `angular/components` repository. We
      need to do this because we removed the `esm5.bzl` output flavour aspect,
      but an old version of the components repo relied on this file to exist.
      
      This is no longer the case, and we can simply update the version of the
      components repo we can test against.
      
      PR Close #37623
      12f674f4
  21. May 19, 2020
  22. May 07, 2020
  23. May 06, 2020
    • Andrew Scott's avatar
      build: remove typescript 3.6 and 3.7 support (#36329) · fbd281c2
      Andrew Scott authored
      Remove TypeScript 3.6 and 3.7 support from Angular along with tests that
      ensure those TS versions work.
      
      BREAKING CHANGE: typescript 3.6 and 3.7 are no longer supported, please
      update to typescript 3.8
      
      PR Close #36329
      fbd281c2
    • Joey Perrott's avatar
      ci: removing CI environment variable caching setup (#36936) · fc6c3ae9
      Joey Perrott authored
      A caching mechanism was put in place to prevent repeated calls to
      the Github API.  As the CI setup no longer relies on calls to the
      Github API, this caching is no longer necessary.
      
      It was discovered that this caching was causing a contention issue
      for saucelabs testing as the same tunnel was being reused for
      multiple jobs simultaneously.  With this caching mechanism removed
      the jobs will once again run via separate tunnels.
      
      PR Close #36936
      fc6c3ae9
  24. Apr 17, 2020
    • Joey Perrott's avatar
      ci: remove reliance on Github API for CI setup (#36500) · 4480ba3e
      Joey Perrott authored
      Previously our CI during the setup process has made requests
      to the Github API to determine the target branch and shas.
      With this change, this information is now determined via git
      commands using pipeline parameters from CircleCI.
      
      PR Close #36500
      4480ba3e
  25. Apr 02, 2020
    • Joey Perrott's avatar
      build: update to clang 1.4.0 and only run clang format on changed files (#36203) · c5c57f67
      Joey Perrott authored
      Update to clang@1.4.0 to gain support for optional changing and nullish
      coalescing.  Because this would trigger a change on >1800 files in the
      repository, also changes our format enforcement to only be run against
      changed files.  This will allow us to incramentally roll out the value
      add of the upgraded clang format.
      
      PR Close #36203
      c5c57f67
  26. Mar 26, 2020
    • Joey Perrott's avatar
      build: ensure that refs and shas for PRs only need to be requested once (#36207) · d37dad82
      Joey Perrott authored
      This is done by requesting the refs and shas for the PR when the
      env.sh script is run.  Additionally, the env.sh script is now setup
      to write all of the environment variables created to a cache file
      and subsequent loads of the environment load the values from there.
      
      The get-refs-and-shas-for-target.js script now also first attempts
      to load the refs and shas from an environment variable before
      falling back to requesting from github via the API.
      
      PR Close #36207
      d37dad82
  27. Mar 12, 2020
    • Greg Magolan's avatar
      build: remove legacy integration test runner (#35985) · 2b6028b6
      Greg Magolan authored
      * integration tests target definitions in integration/BUILD.bazel updated to use a single dict
      * payload tracking for integration tests updated to work under Bazel
      * legacy integration_test CI job removed
      * integration/run_tests.sh script no longer used in CI so it has been updated for running integration tests locally in the legacy way
      
      PR Close #35985
      2b6028b6
  28. Mar 11, 2020
  29. Feb 19, 2020
    • George Kalpakas's avatar
      ci: get rid of the `CI_CHROMEDRIVER_VERSION_ARG` env var (#35381) · 19396769
      George Kalpakas authored
      Previously, we needed to manually specify a ChromeDriver version to
      download on CI that would be compatible with the browser version
      provided by the docker image used to run the tests. This was kept in the
      `CI_CHROMEDRIVER_VERSION_ARG` environment variable.
      
      With recent commits, we use the browser provided by `puppeteer` and can
      determine the correct ChromeDriver version programmatically. Therefore,
      we no longer need the `CI_CHROMEDRIVER_VERSION_ARG` environment
      variable.
      
      NOTE:
      There is still one place (the `bazel-schematics` integration project)
      where a hard-coded ChromeDriver version is necessary. Since I am not
      sure what is the best way to refactor the tests to not rely on a
      hard-coded version, I left it as a TODO for a follow-up PR.
      
      PR Close #35381
      19396769
  30. Feb 13, 2020
  31. Feb 11, 2020
  32. Feb 07, 2020
  33. Jan 28, 2020
  34. Jan 24, 2020
  35. Jan 23, 2020